Deprecated: Role-based S3 access #688
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an automated comment for commit 2ec2527 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
zvonand
force-pushed
the
s3-roles
branch
3 times, most recently
from
d77fbad to
5f8ae4c
Compare
ianton-ru
reviewed
Mar 24, 2025
ianton-ru
previously approved these changes
Apr 6, 2025
36 tasks
|
Cool, but not really usable in cross-account scenarios without external-id support. |
|
Already working on improvement |
Enmk
added a commit
that referenced
this pull request
Jun 2, 2025
25.3 Antalya port of #688 - Role-based S3 access
13 tasks
zvonand
added
duplicate
Enmk
added a commit
that referenced
this pull request
Aug 6, 2025
By reverting those back to upstream/25.6 variant. Those are related to the features that were not merged yet and hence fail: - integration/test_s3_assume_role/test.py - was added by #688 - integration/test_mask_sensitive_info/test.py - was added by #675 - integration/test_s3_cache_locality/test.py - was added by #763
Enmk
added a commit
that referenced
this pull request
Aug 6, 2025
By reverting those back to upstream/25.6 variant. Those are related to the features that were not merged yet and hence fail: - integration/test_s3_assume_role/test.py - was added by #688 - integration/test_mask_sensitive_info/test.py - was added by #675 - integration/test_s3_cache_locality/test.py - was added by #763
Enmk
added a commit
that referenced
this pull request
Aug 6, 2025
By reverting those back to upstream/25.6 variant. Those are related to the features that were not merged yet and hence fail: - integration/test_s3_assume_role/test.py - was added by #688 - integration/test_mask_sensitive_info/test.py - was added by #675 - integration/test_s3_cache_locality/test.py - was added by #763
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Succeeded by #875, this one is no longer needed to be forwardported
Implement role-based S3 access.
If
extra_credentials(role_arn=...)is provided, temporary credentials are requested from AWS STS and used to access S3. AWS credentials (access_key_id,secret_access_key, and optionallysession_token) must be provided to assume the role.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Added AWS IAM role assumption in
s3table function when explicit AWS credentials are specified andextra_credentialsargument containsroleARN.Documentation entry for user-facing changes